Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to fix Issue #267 #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

acsway878787
Copy link
Contributor

No description provided.

@ale5000-git
Copy link
Member

Since it isn't clear, the correct ref is this: microg/GmsCore#267

@mar-v-in
Copy link
Member

@acsway878787 did you try to compile it, did it work?

@acsway878787
Copy link
Contributor Author

@mar-v-in Sorry,I didn't.
I want to compile myself but I'm lack of knowledge in Linux.
I tried to build in Android Studio and it showed error, then I used apktool to make changes but couldn't compile.
Could you give me a hand on this?

@acsway878787
Copy link
Contributor Author

@mar-v-in I'm sorry that I didn't test before create this pull request.
What's bad, I didn't work.
I'll try my best to find out.

@emv412
Copy link

emv412 commented Aug 5, 2018

I can confirm this solves this issue, compiled it and installed on Asus Fonepad 7 (crashed earlier). It seems Asus devices have this problem.

You also need to remove
android:theme="@style/TextAppearance.AppCompat.Title.Inverse"/> from android_external_MicroGUiTools/microg-ui-tools/src/main/res/layout/app_bar.xml
to work as intended.

@ale5000-git
Copy link
Member

@emv412: Could you please open a pull request?

@acsway878787 acsway878787 reopened this Aug 6, 2018
@acsway878787
Copy link
Contributor Author

acsway878787 commented Aug 6, 2018

@emv412 Glad to hear someone find the solution. I didn't pay attention on this after I updated my PFS to MM.Could you explain why this issue will occur?
By the way, I think people who face this problem should build microg on their own with these changes, because merge this PR will change the style of Text somewhere universally, in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants