Generate Creator class for com.google.firebase.dynamiclinks.internal.DynamicLinkData by adding respective annotation #2615
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derMart
changed the title
|
This has also been submitted under #2519 |
|
Since this is already included in #2519 and the PR is already merged it is time to close also this. |
|
@derMart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2596
After refactor via 3ccb5f4 the
@SafeParcelable.Classannotation is still missing incom.google.firebase.dynamiclinks.internal.DynamicLinkData. Also the safe-parcelable process needs to be added to the gradle build file.@mar-v-in When searching for "AbstractSafeParcelable" in the source tree I do see that there are more places where the annotation is missing. If you like, I might fix those with this PR too.
best