Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update runner to latest version (excludes built-in model in C++ files). #24

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

microbit-carlos
Copy link
Contributor

@microbit-carlos microbit-carlos commented Oct 31, 2024

The runner project has also been updated to:

  • Add the option to test the filter and model outputs (none of these files should end up in the extension, this mode is only meant to run in the pxt-microbit-ml-runner repo/project)
  • Remove from the extension (but still present when the runner is built as a MakeCode project) the "built-in model" C++ files. This was useful during initial development, but no need to bring the files into pxt-microbit-ml as part of the pxt-microbit-ml-runner extension.

None of these two changes should have an effect on this extension as used in ml-trainer.
Full diff in the runner: microbit-foundation/pxt-microbit-ml-runner@v0.4.6...v0.4.8

No rush at all to merge this, review when you can.

The runner project has also been updated to test the filter and
model outputs, but none of those files should end up in the
extension either.
@microbit-carlos microbit-carlos changed the title Update runner to latest version (removes built-in C++ model files). Update runner to latest version (excludes built-in model in C++ files). Nov 1, 2024
Copy link
Collaborator

@microbit-robert microbit-robert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@microbit-carlos microbit-carlos merged commit 7fcf971 into main Nov 4, 2024
2 checks passed
@microbit-carlos microbit-carlos deleted the update-runner branch November 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants