Skip to content

Commit

Permalink
Translation preparation (#26)
Browse files Browse the repository at this point in the history
- Tweaks to jsdoc strings for translation to help pxt gendocs tool pick up all strings
- Add MakeCode strings files
- Add "unknown" to translatable strings for sim extension
  • Loading branch information
microbit-robert authored Nov 14, 2024
1 parent 6989765 commit 62ab8f9
Show file tree
Hide file tree
Showing 7 changed files with 40 additions and 6 deletions.
7 changes: 7 additions & 0 deletions _locales/machine-learning-jsdoc-strings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"mlrunner.customOnEvent": "Register a TypeScript function to run when an event is raised.\n* This custom version of the MakeCode onEvent function is needed due to:\nhttps://github.com/microsoft/pxt-microbit/issues/5709\n*",
"mlrunner.customOnEvent|param|flags": "The specified event flags are ignored and configured via pxt.json.",
"mlrunner.customOnEvent|param|handler": "The function to call when the event is detected.",
"mlrunner.customOnEvent|param|src": "The ID of the component to listen to.",
"mlrunner.customOnEvent|param|value": "The event value to listen to from that component."
}
13 changes: 13 additions & 0 deletions _locales/machine-learning-strings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
{
"ml.event.Unknown|block": "unknown",
"ml.getCertainty|block": "certainty (\\%) ML $event",
"ml.isDetected|block": "is ML $event detected",
"ml.onStart|block": "on ML $event start",
"ml.onStopDetailed|block": "on ML $event stop $duration (ms)",
"ml.onStop|block": "on ML $event stop",
"mlrunner|block": "mlrunner",
"{id:category}Ml": "Ml",
"{id:category}MlEvent": "MlEvent",
"{id:category}Mlrunner": "Mlrunner",
"{id:group}micro:bit (V2)": "micro:bit (V2)"
}
4 changes: 2 additions & 2 deletions pxtextension.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -163,11 +163,11 @@ namespace mlrunner {
* This custom version of the MakeCode onEvent function is needed due to:
* https://github.com/microsoft/pxt-microbit/issues/5709
*
*
* @param src The ID of the component to listen to.
* @param value The event value to listen to from that component.
* @param handler The function to call when the event is detected.
* @param flags The specified event flags are ignored and configured via
* pxt.json.
* @param flags The specified event flags are ignored and configured via pxt.json.
*/
//%
void customOnEvent(int src, int value, Action handler, int flags = 0) {
Expand Down
4 changes: 2 additions & 2 deletions shims.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,11 @@ declare namespace mlrunner {
* This custom version of the MakeCode onEvent function is needed due to:
* https://github.com/microsoft/pxt-microbit/issues/5709
*
*
* @param src The ID of the component to listen to.
* @param value The event value to listen to from that component.
* @param handler The function to call when the event is detected.
* @param flags The specified event flags are ignored and configured via
* pxt.json.
* @param flags The specified event flags are ignored and configured via pxt.json.
*/
//% flags.defl=0 shim=mlrunner::customOnEvent
function customOnEvent(src: int32, value: int32, handler: () => void, flags?: int32): void;
Expand Down
4 changes: 4 additions & 0 deletions simx/lang/ui.en.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,9 @@
"select-label": {
"defaultMessage": "ML event:",
"description": "Label for the simulator event select input"
},
"unknown-event-label": {
"defaultMessage": "unknown",
"description": "Label the default ML event"
}
}
8 changes: 6 additions & 2 deletions simx/src/Simulator.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* SPDX-License-Identifier: MIT
*/
import { ChangeEvent, useCallback, useEffect, useRef, useState } from "react";
import { FormattedMessage } from "react-intl";
import { FormattedMessage, useIntl } from "react-intl";
import "./simulator.css";

type MessageType = "register" | "data" | "request_data" | "simulate_event";
Expand All @@ -20,11 +20,15 @@ interface EventData {
}

const simChannel = "microbit-foundation/pxt-microbit-ml";
const defaultEvent: EventData = { name: "unknown", value: 1 };
const textDecoder = new TextDecoder();
const textEncoder = new TextEncoder();

const Simulator = () => {
const intl = useIntl();
const defaultEvent: EventData = {
name: intl.formatMessage({ id: "unknown-event-label" }),
value: 1,
};
const [events, setEvents] = useState<EventData[]>([defaultEvent]);
const [selectedEvent, setSelectedEvent] = useState<number>(
defaultEvent.value
Expand Down
6 changes: 6 additions & 0 deletions simx/src/messages/ui.en.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,5 +4,11 @@
"type": 0,
"value": "ML event:"
}
],
"unknown-event-label": [
{
"type": 0,
"value": "unknown"
}
]
}

0 comments on commit 62ab8f9

Please sign in to comment.