Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limits characters that can be inserted as an action title #73

Closed
wants to merge 4 commits into from

Conversation

Marisa-Jenkins
Copy link
Collaborator

@Marisa-Jenkins Marisa-Jenkins commented Dec 20, 2023

Limits the number of characters that can be inputted including when pasted from the clipboard. The cross icon has also been changed to match the new design.

image

Closes #65

Copy link

cloudflare-workers-and-pages bot commented Dec 20, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 1d3b307
Status: ✅  Deploy successful!
Preview URL: https://741b5c24.ml-trainer.pages.dev
Branch Preview URL: https://action-title-paste-limiter.ml-trainer.pages.dev

View logs

@microbit-matt-hillsdon
Copy link

The experience is a bit weird at the moment when you click on a newly added action's input: the text goes from black to grey (actual text is removed, placeholder appears but the user doesn't know that).

I think ideally we'd replace this with a "click to edit" UX - we'll discuss with Lucy in the New Year what's worthwhile here.

@microbit-matt-hillsdon microbit-matt-hillsdon marked this pull request as draft December 21, 2023 10:33
@microbit-matt-hillsdon
Copy link

We'll pick this up separately from this PR.

@microbit-matt-hillsdon microbit-matt-hillsdon deleted the action-title-paste-limiter branch January 10, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit length of text that can be pasted into an action title
2 participants