Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flip pairing input labels so column number is first #529

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Flip pairing input labels so column number is first #529

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lang/ui.en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@
"description": "Heading for Bluetooth pattern connection dialog"
},
"connect-pattern-input-label": {
"defaultMessage": "Number of LEDs lit in column {colNum} on the micro:bit display",
"defaultMessage": "Column {colNum} - number of LEDs lit on the micro:bit display",
"description": "Screenreader text for numeric pattern input"
},
"connect-pattern-subtitle": {
Expand Down
1 change: 0 additions & 1 deletion src/components/BluetoothPatternInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ const PatternColumnInput = ({
<FormattedMessage
id="connect-pattern-input-label"
values={{ colNum: colIdx + 1 }}
sr-onlu
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's already in a VisuallyHidden component, and this prop obviously does nothing.

/>
</FormLabel>
</VisuallyHidden>
Expand Down
4 changes: 2 additions & 2 deletions src/messages/ui.en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -418,15 +418,15 @@
"connect-pattern-input-label": [
{
"type": 0,
"value": "Number of LEDs lit in column "
"value": "Column "
},
{
"type": 1,
"value": "colNum"
},
{
"type": 0,
"value": " on the micro:bit display"
"value": " - number of LEDs lit on the micro:bit display"
}
],
"connect-pattern-subtitle": [
Expand Down
Loading