Foundation deployment #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've deleted the upstream workflows rather than disable them for clarity. Will always be easy to reinstate if needed.
Deploying with
|
| Latest commit: |
44c770b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://d969778a.ml-trainer.pages.dev |
| Branch Preview URL: | https://deployment.ml-trainer.pages.dev |
|
Not worrying too much about the conflicts here for now. It might make sense for me to redo once current image changes are finalised. |
- Vite base URL now works - Images are hashed for deployment so can be cached - Ignore images in src for the licensing check
microbit-matt-hillsdon
force-pushed
the
deployment
branch
from
ab32cbd
to
cae6018
Compare
|
The latest build is the first that isn't obviously broken: https://review-ml.microbit.org/deployment/ Will properly test the flows tomorrow. |
microbit-matt-hillsdon
force-pushed
the
deployment
branch
from
04aa558
to
e7ccac7
Compare
Assets is a Vite managed folder - the model files are not hashed so not safe to cache unlike everything else Not easy to convert to be imported as one file references the other. There's probably a Vite plugin that could do the job but one for another time.
microbit-matt-hillsdon
force-pushed
the
deployment
branch
from
e7ccac7
to
c6846d4
Compare
|
It works at least as well as main (radio bridge flow is broken, a bunch of images are placeholders). |
micque01
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've deleted the upstream workflows rather than disable them for clarity. Will always be easy to
reinstate if needed.
Non-trivial aspects:
all.min.csssource so not entirely clear what's going wrong.all.min.cssis deployed to the root but references the fonts with ../webfonts/... this works because ../ at the root is ignored but at any other path it breaks. Maybe it was always intended to have a CSS directory? I've done that for now.public/assetsis probably just not a good idea.