Merge pull request #58 from microbit-foundation/remove-training-dialog

Remove training dialog

src/pages/DataPage.svelte

@@ -123,6 +123,6 @@
 
       <NewGestureButton />
     </div>
-    <TrainingButton />
+    <TrainingButton type="navigate" />
   {/if}
 </main>

src/pages/training/TrainingButton.svelte

@@ -9,10 +9,11 @@
   import StandardButton from '../../components/StandardButton.svelte';
   import { trainModel } from '../../script/ml';
   import { t } from '../../i18n';
-  import StandardDialog from '../../components/dialogs/StandardDialog.svelte';
   import { Paths, navigate } from '../../router/paths';
   import { gestures } from '../../script/stores/Stores';
 
+  export let type: 'navigate' | 'train' = 'train';
+
   $: trainButtonLabel = !$state.isPredicting
     ? 'menu.trainer.trainModelButton'
     : 'menu.trainer.trainNewModelButton';
@@ -28,36 +29,19 @@
     trainingDialogOpen = false;
   };
 
-  const startTraining = async (): Promise<void> => {
+  const startTraining = () => {
     closeTrainingDialog();
+    trainModel();
+  };
+
+  const navitgateToTrainingPage = () => {
     navigate(Paths.TRAINING);
-    const shouldRedirect = await trainModel();
-    if (shouldRedirect) {
-      navigate(Paths.MODEL);
-    }
   };
 </script>
 
 <StandardButton
-  onClick={() => {
-    trainingDialogOpen = true;
-  }}
+  onClick={type === 'navigate' ? navitgateToTrainingPage : startTraining}
   disabled={trainingButtonDisabled}
   type="primary"
   >{$t(trainButtonLabel)}
 </StandardButton>
-
-<StandardDialog
-  isOpen={trainingDialogOpen && !$state.isTraining}
-  onClose={closeTrainingDialog}>
-  <div class="w-150">
-    <h1 class="text-xl font-bold mb-4">{$t('content.data.trainDialog.title')}</h1>
-    <p>{$t('content.data.trainDialog.text')}</p>
-    <div class="flex justify-end gap-3">
-      <StandardButton onClick={closeTrainingDialog}
-        >{$t('connectMB.backButton')}</StandardButton>
-      <StandardButton type="primary" onClick={startTraining}
-        >{$t('content.data.trainDialog.title')}</StandardButton>
-    </div>
-  </div>
-</StandardDialog>