Remove open settings dialog shortcut

There is ambiguity as to which keys to use and there needs to be a way of disabling certain keys when dialogs are open
microbit-foundation · Dec 3, 2024 · 088a428 · 088a428
1 parent 456dc6a
commit 088a428
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 6 deletions.
diff --git a/src/components/ActionBar/ActionBarItemsRight.tsx b/src/components/ActionBar/ActionBarItemsRight.tsx
@@ -52,11 +52,6 @@ const ItemsRight = ({ menuItems, toolbarItems }: ItemsRightProps) => {
       }
     }
   }, [tourTriggerName]);
-  useHotkeys(
-    keyboardShortcuts.settings,
-    settingsDisclosure.onOpen,
-    globalShortcutConfig
-  );
   return (
     <>
       <LanguageDialog

diff --git a/src/keyboard-shortcuts.ts b/src/keyboard-shortcuts.ts
@@ -3,7 +3,6 @@ export const keyboardShortcuts = {
   // This is scoped by keyboard focus.
   addAction: ["ctrl+shift+enter", "meta+shift+enter"],
   saveSession: ["ctrl+shift+s", "meta+shift+s"],
-  settings: ["ctrl+shift+p", "meta+shift+p"],
   nextAction: ["down"],
   previousAction: ["up"],
   renameAction: ["F2"],