Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement pin.calibrate() method. #222

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Implement pin.calibrate() method. #222

merged 2 commits into from
Sep 16, 2024

Conversation

dpgeorge
Copy link
Collaborator

@dpgeorge dpgeorge commented Sep 9, 2024

Added only to pins that have touch capabilities.

Addresses issue #209.

@dpgeorge
Copy link
Collaborator Author

dpgeorge commented Sep 9, 2024

Maybe it should be called pin.touch_calibrate() to make it clear what it does?

@microbit-carlos
Copy link
Contributor

Thanks Damien!

Maybe it should be called pin.touch_calibrate() to make it clear what it does?

Yeah, that's a good call, I agree that name is better.

@dpgeorge
Copy link
Collaborator Author

Updated to change the name to touch_calibrate().

Copy link
Contributor

@microbit-carlos microbit-carlos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works great, thanks Damien!

@dpgeorge dpgeorge merged commit 3f22f30 into master Sep 16, 2024
6 checks passed
@dpgeorge dpgeorge deleted the pin-calibrate branch September 16, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants