Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relabel and arrange menu items #55

Closed
wants to merge 5 commits into from
Closed

Conversation

microbit-grace
Copy link
Collaborator

@microbit-grace microbit-grace commented Apr 10, 2024

Task: https://microbit-global.monday.com/boards/1162890768/pulses/1457889927

Update menu items ordering so that it is more like the iOS app:

  • Create Code
  • My Programs
  • Manage Connections
  • Project Ideas

so that the ordering is now:
- Create Code
- My Programs
- Manage Connections
- Project Ideas

Like the iOS app
@martinwork
Copy link
Collaborator

@microbit-grace @jaustin

I already did this in my branch with the new flash-pair flow
https://github.com/martinwork/microbit-android/tree/new-flash-pair-flow

I wondered if "Manage Connections" might be too long as a page tile on some phones, and if it was was unnecessarily grand for Pair. The iOS app supports more than one pairing and removing a connection.

It all looks good, so I am happy for you to merge, and I'll fix up my branch.

@microbit-grace
Copy link
Collaborator Author

microbit-grace commented Apr 10, 2024

I wondered if "Manage Connections" might be too long as a page tile on some phones, and if it was was unnecessarily grand for Pair. The iOS app supports more than one pairing and removing a connection.

Interesting point, I have forwarded the message to Lucy to see what she thinks on Monday.com 😄

Edit: Jonny agreed to use "Pair". I will change to use "Pair" bd8b863

@microbit-grace
Copy link
Collaborator Author

Thanks @martinwork, I have reverted the change from "Manage Connections" to "Pair and copied your change from your new flash flow PR so that the header in the My Programs page is also updated to not show "Flash"

@martinwork
Copy link
Collaborator

Oh yes @microbit-grace, I had forgotten about needing to make that change. Beware... I seem to remember one or two of those strings were reused in not-really-related places... or maybe it was just that there were two strings for Flash.

@microbit-grace
Copy link
Collaborator Author

microbit-grace commented Apr 11, 2024

@martinwork Yes, I noticed that there were confusingly another "Flash" string, but I think that's for the Flash button.

I have also changed the landscape main activity button styling to have textAllCaps: false (55a9d39). If we want all the other buttons to not be fully capitalised, I think I might do it in a separate PR. If you are happy with changes, I shall squash and merge. Many thanks!

@microbit-matt-hillsdon
Copy link

Closing in favour of #63.

@microbit-matt-hillsdon microbit-matt-hillsdon deleted the rearrange-screen-items branch May 2, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants