Update sdk_config to support all services including HF2 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@martinwork is this still required? |
|
@microbit-carlos Yes, now would be a good time to merge. It allows for a MakeCode project to include all standard BLE services, including its HF2 console service. Or alternatively to allow for some services we don't know about. If I had the right numbers, the RAM ORIGIN in the linker file was set in lancaster-university/codal-microbit-v2#52 to reserve the space for this PR to be merged. So at the moment, there's a little unused RAM below (above?) the origin. The origin was here: https://github.com/lancaster-university/codal-microbit-v2/blob/b4552c76ff6b9fefa7f0d113776daa6a0f1afda5/ld/nrf52833.ld#L9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.