-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use profiles for language #631
Conversation
Signed-off-by: Daena Rys <[email protected]>
Did you render the book? I rendered it but it seems that these modifications do not have any effect? |
Yes, for now they don't have any direct effect but would only be useful if there is a long term ambition to translate OMA to other languages where for example we could link qmd sections to specific profiles: |
Translating the book would be nice but it is not realistic (at least currently). Translating it to different language would require lots of work and cause maintenance issues. OMA book is updating continuously and we do not have time or expertise to keep the translated versions up-to-date. In fact, the tutorial workflows are not up-to-date either. If this current PR does not modify the book, I think we can close the PR and modify the book when needed. Would it be possible to add this kind of option only for the tutorial workflow (so that it does not affect the whole book)? That might be feasible. Moreover, we have to decide at some point the correct place for these workflows. The optimal place might be in OMA, but there could be separate book for them. It might be problematic if we have the same workflow multiple times with different languages in OMA. |
Right.
I agree
We currently have a hard-coded language selector in the tutorial workflow that helps in switching the languages. Since multi-language is not needed immediately the option is not really necessary. Though it could be a start in managing updates across different languages in a single sweep
right. it seems the workflows could be rendered per profile basis. and as you have rightly put, having separate book could be a good thing but the downside would be the complexity of updating the books simultaneously. alternatively different language profiles could be stored in subdirectories while the primary language used the main index. |
Good points. I think we should have only translations in tutorial workflow (if any). This should not take our time too much. Comments are not necessary if the translation is otherwise ok. (But currently the code chunks also differ in different languages of tutorial workflows...) --> I suggest that we close this PR now and solve this issue when OMA is more ready. (These workflows can also be moved to extra material.) Anyways, we are not going to translate the whole book, so these changes in this PR are not required |
sounds good. closing pr now. |
#580