Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Build: Adds imagej dependency #631

Closed
wants to merge 1 commit into from
Closed

Fix Build: Adds imagej dependency #631

wants to merge 1 commit into from

Conversation

nicost
Copy link
Member

@nicost nicost commented Jul 11, 2023

and add relevant imports to LIghtSheetStackTest. It is unclear if this was the intention. Closes #626.

imports to LIghtSheetStackTest.  It is unclear if this was the intention.
@nicost nicost requested a review from henrypinkard July 11, 2023 17:34
@ieivanov
Copy link
Collaborator

Thanks Nico! I think things break at the Deploy PycroManagerJava.jar to Sonatype OSS step, which only runs when a branch is merged into main (I think). So we are yet to see if these changes have fixed the build bug.

I believe Henry's intention was not to make pycromanager explicitly depend on ImageJ. @henrypinkard is there a better place where the LightSheetStackTests can live?

@henrypinkard
Copy link
Member

Yes, Im not sure how I ended up merging this in the first place, but these tests are for manual local testing, and imageJ is just for displaying images. So I've just commented out this class for now in #632

@henrypinkard
Copy link
Member

I think things break at the Deploy PycroManagerJava.jar to Sonatype OSS step, which only runs when a branch is merged into main (I think)

Ah yes, I think that is right. I made a new issue for this #633

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LightSheetStackTests is causing some tests to fail
3 participants