Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement std::exception for MetadataError #532

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −1
Open

implement std::exception for MetadataError #532

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfd56f7
implement std::exception for MetadataError
tlambert03 Dec 1, 2024
2ace58c
include key in error
tlambert03 Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion MMDevice/ImageMetadata.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,9 @@ class MetadataError
return message_;
}

/// Implements std::exception interface.
virtual const char* what() const throw() { return message_.c_str(); }

private:
std::string message_;
};
Expand All @@ -64,6 +67,8 @@ class MetadataKeyError : public MetadataError
public:
MetadataKeyError() :
MetadataError("Undefined metadata key") {}
MetadataKeyError(const char* key) :
MetadataError(("Undefined metadata key: " + std::string(key)).c_str()) {}
~MetadataKeyError() {}
};

Expand Down Expand Up @@ -487,7 +492,7 @@ class Metadata
if (it != tags_.end())
return it->second;
else
throw MetadataKeyError();
throw MetadataKeyError(key);
}

std::map<std::string, MetadataTag*> tags_;
Expand Down
Loading