Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightSheetManager: use C++17 in debug and release mode #497

Closed
wants to merge 1 commit into from

Conversation

bls337
Copy link
Contributor

@bls337 bls337 commented Sep 23, 2024

No description provided.

@marktsuchida
Copy link
Member

@bls337 Would it be okay if we left it set to C++14 until the code actually requires C++17?

In part because we'll also need to enable C++17 for the Mac/Linux build, and it will be good to test all when merging the code that uses C++17 features (there are no other device adapters using C++17 on Mac/Linux yet, even though I did do a preliminary test that it should work).

Same for #495 and #496 as well.

(You are welcome to start using C++17 features whenever you like.)

@bls337
Copy link
Contributor Author

bls337 commented Sep 27, 2024

@marktsuchida That works for me, I was curious about how much of a pain it would be to enable right now. If it's easier to just leave it at C++14 for now we should do that. I will enable it if I take advantage of the new C++ features.

@bls337 bls337 closed this Sep 27, 2024
@marktsuchida
Copy link
Member

@bls337 Thanks. I don't expect it to be a pain, but it will be good to keep the build scripts in sync.

@bls337 bls337 deleted the LightSheetManager branch September 30, 2024 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants