Revert pull request #476 #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The check for an initialized hub was already in HubInstance.
|
Oh good catch! Sorry I missed it too! I actually think it's more likely I hadn't set the feature flag in my usage than it is that it's not functioning. Revert is fine, sorry for the noise |
|
Not a problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check for an initialized hub was already in HubInstance.
@tlambert03 Sorry I missed this while reviewing #476. See
mmCoreAndDevices/MMCore/Devices/HubInstance.cpp
Line 36 in 36c45e6
which is in the code path of
getInstalledDevices().Is it possible that the above check is not functioning (with the
StrictInitializationChecksfeature enabled)? If so, let me know how to reproduce. It should also log a warning with the feature disabled.