Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MMDevice: Deprecate functions #437

Merged
merged 1 commit into from
Jan 24, 2024
Merged

MMDevice: Deprecate functions #437

merged 1 commit into from
Jan 24, 2024

Conversation

marktsuchida
Copy link
Member

Of these, here are the functions currently used by device adapters on Windows:

DeviceAdapters\FakeCamera\FakeCamera.cpp(461,25): warning C4996: 'MM::Core::GetFocusPosition': was declared deprecated
DeviceAdapters\TwoPhoton\VirtualShutter.cpp(124,46): warning C4996: 'MM::Core::GetSignalIODevice': was declared deprecated
DeviceAdapters\TwoPhoton\VirtualShutter.cpp(132,46): warning C4996: 'MM::Core::GetSignalIODevice': was declared deprecated
DeviceAdapters\TwoPhoton\VirtualShutter.cpp(153,46): warning C4996: 'MM::Core::GetSignalIODevice': was declared deprecated
DeviceAdapters\TwoPhoton\VirtualShutter.cpp(168,46): warning C4996: 'MM::Core::GetSignalIODevice': was declared deprecated

(It's good to deprecate these to warn against future use even if we end up keeping the used functions for some time.)

- Those discussed in #295
- Get/SetModuleHandle(), which were deprecated in comment
- Direct access to device pointers, deprecated in comment
@marktsuchida marktsuchida merged commit 3e044e8 into main Jan 24, 2024
3 checks passed
@marktsuchida marktsuchida deleted the mmdevice-deprecate branch January 24, 2024 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant