MMDevice/MMCore[J]: Remove unused macro defs #436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove preprocessor definitions from MMDevice/MMCore/MMCoreJ_wrap .vcxproj files This is to maintain the cleanup done in #415 (specifically, 4536cc0) -- to prevent the vcxproj build from going out of sync with the experimental Meson build. - `_DEBUG` - the compiler defines this when using the debug runtime; redundant - `_LIB` - added by VS by default for static libs; we don't use it - `_USRDLL` - added by VS by default for DLLs; we don't use it - `_WINDOWS` - added by VS by default; we don't use it - `WIN32` - added by VS by default; we prefer `_WIN32`, defined by the compiler Also delete the single use of `_DEBUG` in `CMMCore::getVersionInfo()`. It is better not to produce a different version string in a debug build, because applications may parse this string (for example, a pymmcore test does that). All the other macros removed here are not currently used in these projects.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove preprocessor definitions from MMDevice/MMCore/MMCoreJ_wrap .vcxproj files
This is to maintain the cleanup done in #415 (specifically, 4536cc0) -- to prevent the vcxproj build from going out of sync with the experimental Meson build.
_DEBUG- the compiler defines this when using the debug runtime; redundant_LIB- added by VS by default for static libs; we don't use it_USRDLL- added by VS by default for DLLs; we don't use it_WINDOWS- added by VS by default; we don't use itWIN32- added by VS by default; we prefer_WIN32, defined by the compilerAlso delete the single use of
_DEBUGinCMMCore::getVersionInfo(). It is better not to produce a different version string in a debug build, because applications may parse this string (for example, a pymmcore test does that).All the other macros removed here are not currently used in these projects.