-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Packaging #153
Packaging #153
Conversation
e846e19
to
a8c99a3
Compare
This looks pretty good to me, but as an FYI I'm not able to test it fully on OS X (since I only have a junky old 10.6.8 install that seems to be choking on a few things). So in the build-pkg script I had to change clang to gcc, and I had to comment out the pandoc part too. After that, it seemed to work and the app bundle seemed to run ok. One thing I don't fully understand though is this output from otool, run against the sfml graphics dylib in the bundle's lib directory: otool -L libsfml-graphics.2.1.dylib The second and third lines are mapped to @executable_path/../Frameworks... which doesn't exist, yet the program still runs for me !? I don't know why this would still run, it must be falling back on my system's SFML lib. I seem to only have SFML 2.1 installed, I don't recall if it is from the SFML site or homebrew. Anyways, I'll try to test this out on linux tomorrow and then merge, thanks! |
I think it's reasonable to remove the CC, CXX, etc hard-codes to just pass overrides in $@. Makefile defaults are respected that way. Will do that tomorrow.
That is odd. It's almost as if you have both a framework and lib somewhere?
Yes, it is. Happened to me with another project so I started testing on a clean VM. For my linux osxcross environment, I built universal packages for SFML and FFMPEG using the real macports on a 10.7 vm, then copied them over. If i was going to do it again, I would edit the macport definitions before compiling to cut down on the necessary libs. |
Here's the output from /usr/local/lib/libsfml-graphics.2.1.dylib otool -L libsfml-graphics.2.1.dylib |
should support native and osxcross building
src/fe_overlay.cpp:1027:11: warning: using integer absolute value function 'abs' when argument is of floating point type [-Wabsolute-value]
* for cross packaging, use libdmg-hfsplus to make the filesystem
Conditional pandoc support, otherwise just rename .md to .txt Add error messages if cross-packaging commands missing
4735700
to
172768a
Compare
Ok, it's merged! I'm hoping to use an OS X build from your buildbot as the 'official' OS X package for 1.6.0, my mac just isn't up for the task anymore. |
OSX packaging, changelog generator, and a little patch to the line-ending changer.