Merge pull request #12 from tomchkk/master

Adds millisecond support
michielfb · Sep 12, 2022 · 97a80a1 · 97a80a1
2 parents 8b19943 + b10abab
commit 97a80a1
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 10 deletions.
diff --git a/dist/js/field.js b/dist/js/field.js
diff --git a/resources/js/components/DetailField.vue b/resources/js/components/DetailField.vue
@@ -24,7 +24,7 @@ export default {
     computed: {
         formattedDate() {
             return this.field.value
-                ? moment(this.field.value, 'HH:mm:ss').format(this.field.format)
+                ? moment(this.field.value, this.field.format).format(this.field.format)
                 : '-';
         }
     }

diff --git a/resources/js/components/FormField.vue b/resources/js/components/FormField.vue
@@ -10,10 +10,6 @@
                    :step="field.step !== undefined ? field.step : false"
                    v-model="value"
             />
-
-            <p v-if="hasError" class="my-2 text-danger">
-                {{ firstError }}
-            </p>
         </template>
     </default-field>
 </template>

diff --git a/resources/js/components/IndexField.vue b/resources/js/components/IndexField.vue
@@ -9,9 +9,9 @@ export default {
     computed: {
         formattedDate() {
             return this.field.value
-                ? moment(this.field.value, 'HH:mm:ss').format(this.field.format)
+                ? moment(this.field.value, this.field.format).format(this.field.format)
                 : '-';
         }
     }
 }
-</script>
+</script>
diff --git a/src/Time.php b/src/Time.php
@@ -28,11 +28,16 @@ public function format(string $format = 'hh:mm A')
     /**
      * Set step attribute on time field.
      *
-     * @param int $step
+     * For seconds:
+     *  - use integers that will eventually reach 60 - e.g.: 1, 2, 10, 30
+     * For milliseconds:
+     *  - use floats that eventually will reach 1 - e.g.: 0.001, 0.050, 0.200, etc.
+     *
+     * @param int|float $step
      *
      * @return $this
      */
-    public function withSteps(int $step)
+    public function withSteps($step)
     {
         return $this->withMeta([
             'step' => $step