-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
defined show
and show_in_iruby
methods
#236
base: master
Are you sure you want to change the base?
Conversation
Ping @michelson |
lib/lazy_high_charts.rb
Outdated
end | ||
|
||
# generate initializing code | ||
def self.generate_init_code(assets=:inline) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assets= :cdn
is not working . I don't know why.
@@ -10,6 +10,10 @@ def high_chart(placeholder, object, &block) | |||
high_graph(placeholder, object, &block).concat(content_tag("div", "", object.html_options)) | |||
end | |||
|
|||
def high_chart_iruby(placeholder, object, &block) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Display nothing. @michelson can you check why it doesn't work ?
@michelson , if this PR is merged, then it will be very helpful for me to use it in Daru gem and plugin gem daru-view. So please try to review it as soon as possible. |
Hi @Shekharrajak , this looks good!. Could you provide an example in spec/dummy for iruby in order to do some integration tests? best! |
show
and show_in_iruby
methods
0824718
to
c7a6259
Compare
7900453
to
1989e71
Compare
@michelson , I hope, now it is good to go. |
Using
|
Most of the time developers and users try their code in iruby notebook. So it will be very helpful if lazy_high_charts is usable in iruby notebook. I have tried one example and pushed in this branch. You can check it in this link : http://nbviewer.jupyter.org/github/Shekharrajak/lazy_high_charts/blob/iruby_setup/examples/notebook/lazy_high_charts.ipynb It will be helpful for me to continue my work on daru-view, if this PR is merged as soon as possible. Thanks. |
Hi Shekhar, thanks for this contribution ,
I guess this will be very helpful for iruby users. Let me check this out ,
do some tests and merge this PR asap
regards from Chile
Atte.
Miguel Michelson Martinez
www.vadb.org <http://vadb.org>
…On Mon, Jun 5, 2017 at 6:26 AM, Shekhar Prasad Rajak < ***@***.***> wrote:
Most of the time developers and users try their code in iruby notebook. So
it will be very helpful if lazy_high_charts is usable in iruby notebook. I
have tried one example and pushed in this branch. You can check it in this
link : http://nbviewer.jupyter.org/github/Shekharrajak/lazy_high_
charts/blob/iruby_setup/examples/notebook/lazy_high_charts.ipynb
It will be helpful for me to continue my work on daru-view, if this PR is
merged as soon as possible. Thanks.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#236 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAAuyKXd68HkcJqs2QMs_9rjKPEmlqOWks5sA8m1gaJpZM4NvB8A>
.
|
Hi @Shekharrajak ,
btw I'm having troubles to run the notebook, all the output is turned to text, so is no chart. but I can see the example you pointed on jupyter.org correctly regards |
Thanks for review . @michelson are you getting nothing in output cell of the notebook, when you run |
I have added more examples in Please check the last example, why it is failing. I think that is other issue. |
yup , I'm not seeing any html output for the graph i'm doing I've updated the gemfile as follows:
is this working for you on local environment ? I get some errors just after notebook starts , |
is needed for iruby notebook. You can try it with 2.3 ruby see : https://stackoverflow.com/questions/35999925/kernel-dies-when-creating-iruby-notebook
When you do print preview in iruby notebook you will be able to see the chart. I also got the same problem I didn't understand why. |
@michelson , I think for 3d charts need to use |
Problem is |
Fixes #235
e.g. in iruby notebook :
I am not able to understand why
high_chart_iruby("some_id1", chart)
not working.