Fixes a notice in count and countBy methods when aggregation result i…

…s empty
micheleangioni · May 29, 2018 · f2aedea · f2aedea
1 parent 4912dc7
commit f2aedea
Showing 1 changed file with 9 additions and 12 deletions.
diff --git a/src/PhalconRepositories/AbstractCollectionRepository.php b/src/PhalconRepositories/AbstractCollectionRepository.php
@@ -224,7 +224,7 @@ public function getIn(string $whereInKey, array $whereIn = [], string $orderBy =
 
         return $this->model->find($input);
     }
-    
+
     /**
      * Return the first ordered $limit records querying input parameters.
      * $limit = 0 means no limits.
@@ -272,7 +272,7 @@ public function getInAndWhereByPage(int $page = 1, int $limit = 10, string $wher
         }
 
         return $this->model->find($input);
-    }   
+    }
 
     /**
      * Return the first ordered $limit records querying input parameters.
@@ -726,15 +726,8 @@ public function truncate()
      */
     public function count()
     {
-        $aggregateArray = [
-            [
-                '$count' => 'number'
-            ]
-        ];
 
-        $result = $this->model::aggregate($aggregateArray);
-
-        return $result->toArray()[0]['number'];
+        return $this->countBy([]);
     }
 
     /**
@@ -759,9 +752,13 @@ public function countBy(array $match = [])
             '$count' => 'number'
         ];
 
-        $result = $this->model::aggregate($aggregateArray);
+        $result = $this->model::aggregate($aggregateArray)->toArray();
+
+        if (count($result)) {
+            return $result[0]['number'];
+        }
 
-        return $result->toArray()[0]['number'];
+        return 0;
     }
 
     /**