Add onDrawn callback #2
Conversation
| @@ -159,7 +163,14 @@ export default class SSVG { | |||
| if(this.renderer.updatePropertiesFromQueue) { | |||
| this.renderer.updatePropertiesFromQueue(queue); | |||
| } | |||
|
|
|||
| if(Object.keys(queue).length === 0) { | |||
There was a problem hiding this comment.
Why is this block of code needed?
There was a problem hiding this comment.
It's basically the same if-condition as used for the worker updating (line 154-158). Here, this ensures that this.renderer.draw() as well as this.logDrawn() are only called when something changed and not on every frame.
There was a problem hiding this comment.
I still don't understand it though. I do get that we use the same code for the worker, but the worker uses a different scheduling mechanism than the same thread method. As you can see in lines 70-80, for the version without the worker, updateCanvas is already continuously being called for every frame.
As far as I can see, what you are doing here is changing the scheduling mechanism for the non-worker method of ssvg. Is this actually related to what this pull request is trying to do? How is it related?
.idea/watcherTasks.xml
Outdated
| @@ -1,7 +1,7 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project version="4"> | |||
| <component name="ProjectTasksOptions"> | |||
| <TaskOptions isEnabled="true"> | |||
There was a problem hiding this comment.
Could you remove this change please? This file should probably not be in the repo in the first place, but let's remove this change from this changelist.
There was a problem hiding this comment.
Ooops, sorry. I've reverted it now.
In some situations, it is necessary to react every time the canvas was updated (e.g., for some post processing). Therefore, this PR introduces a new init parameter
onDrawntaking a callback function that is triggered every time the canvas was redrawn.The callback get's triggered within the
logDrawnmethod.Small adjustment when
logDrawnis called inside ssvg were made.