Update esql tab #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes elastic#166135 Depends on elastic/ingest-docs#474 This PR adds: 1. Subtitle under Topic Processors linking to docs 2. Removes whitespace stripping from `value` in `key:value` topic pair. 
…67012) ## Summary When a user is writing am ES|QL query with the enrich command and doesn't have a policy then we want to navigate them from the editor to the index management page to create one. In the future the same action can open a flyout in order for the users to not change context but we don't have it atm.  --------- Co-authored-by: Marco Liberati <[email protected]>
## Summary Fixes elastic#160295 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…lastic#167164) ## Summary - Closes elastic#166854 by disabling the Observability Log Explorer plugin in the es and security serverless projects. - Closes elastic#166912 by expanding results with `keywords`. --------- Co-authored-by: Kibana Machine <[email protected]>
## Summary We're breaking elastic#166813 up into smaller PRs in the interest of getting PRs through sooner for type fixes. These are the changes for ML UI. --------- Co-authored-by: Dima Arnautov <[email protected]>
## 📓 Summary Closes elastic#167011 This implementation fixes the persisted beta badge after leaving the Log Explorer profile, restoring any existing element on the mount point as a clean-up action. https://github.com/elastic/kibana/assets/34506779/3214e097-2c82-4b09-8310-ad09eb4c5a18 Co-authored-by: Marco Antonio Ghiani <[email protected]>
## Summary We're breaking elastic#166813 up into smaller PRs in the interest of getting PRs through sooner for type fixes. These are the changes for Platform Deployment Management. Co-authored-by: Kibana Machine <[email protected]>
) ## Summary Closes elastic#162263 Introduces a new `Feature Privileges` section to the developer documentation. The documentation includes a tutorial on how to control access to features of plugin being developed. Introduces a few sections: - Controlling access to UI features - Controlling access to server side APIs - Documentation for configuration options ## Testing To build this locally, run ./scripts/dev_docs from a local checkout of this PR. A server will eventually start on http://localhost:3000 where you can preview the changes. --------- Co-authored-by: kibanamachine <[email protected]>
## Summary Fixed issue: elastic#165552 for all existing locale. Looked before: <img width="1049" alt="Screenshot 2023-09-19 at 12 24 08" src="https://github.com/elastic/kibana/assets/26089545/540af16a-d5e9-4965-b13b-0e28733ed947"> Now looks like this: <img width="1225" alt="Screenshot 2023-09-19 at 12 19 49" src="https://github.com/elastic/kibana/assets/26089545/58fdffdb-8516-4690-b026-d59ce02a0374"> --------- Co-authored-by: Kibana Machine <[email protected]>
## Summary In cypress tests, when the logs are output in the beginning, some binary buffers are also stringified, so when looking at logs, we have to scroll through thousands of lines of logs, that's annoying and doesn't help debugging. I'd like that to be somewhat more readable, there are a few options: - the replacer should interpret buffers as strings, try to output it like that - not every binary buffer is printable - the replacer should redact the exact fields (certificateAuthority?) - too specific, might need fixing later - trim long arrays after 32 items - I chose this as a solution Other suggestions are welcome. <img width="666" alt="Screenshot 2023-09-27 at 12 49 54" src="https://github.com/elastic/kibana/assets/4738868/7d35e59d-fb14-4d2a-9225-277cc2e1519b">
## Summary This unused parameter is causing typescript error in many builds: https://buildkite.com/elastic/kibana-pull-request/builds/162839#018ad64e-f2db-4572-a2df-2a9257777077 ``` proc [tsc] x-pack/plugins/transform/public/app/sections/create_transform/components/step_define/step_define_form.tsx:358:19 - error TS2322: Type '{ frozenDataPreference: FrozenTierPreference; setFrozenDataPreference: (value: FrozenTierPreference \| undefined) => void; dataView: DataView; query: undefined; disabled: false; timefilter: TimefilterContract; hideFrozenDataTierChoice: boolean; }' is not assignable to type 'IntrinsicAttributes & FullTimeRangeSelectorProps & { children?: ReactNode; }'. -- | proc [tsc] Property 'hideFrozenDataTierChoice' does not exist on type 'IntrinsicAttributes & FullTimeRangeSelectorProps & { children?: ReactNode; }'. | proc [tsc] | proc [tsc] 358 hideFrozenDataTierChoice={!showNodeInfo} ```
## Summary We're breaking elastic#166813 up into smaller PRs in the interest of getting PRs through sooner for type fixes. These are the changes for `x-pack/test_serverless`. ## Reviewers There are no code owners for these files, so I'm using the recently edited suggestions --------- Co-authored-by: Alex Szabo <[email protected]> Co-authored-by: Thomas Watson <[email protected]> Co-authored-by: Alex Szabo <[email protected]> Co-authored-by: Thomas Watson <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
## Summary Supposedly, this is the error that's causing these type of errors:/ ``` Cannot write file '/Users/alex/Git/kibana/x-pack/test/functional/services/random.js' because it would overwrite input file. ``` Separated off from: elastic#167355 Co-authored-by: Thomas Watson <[email protected]> Co-authored-by: Kibana Machine <[email protected]>
…lastic#167121) ## Summary a follow-up for elastic#166966 to add unit tests
…lastic#167111) ## Summary Save to library action should not be present in ES|QL panels. For now we only allow by value embeddables and we don't want them to be edited/created in Lens editor <img width="915" alt="image" src="https://github.com/elastic/kibana/assets/17003240/d6e5e8a7-459f-4b1d-8461-2863b45db882"> ### Checklist - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
The `chi2test` utils so fare were only used within data comparison view. We plan to use it with other plugins, so moving it so a separate package in this PR. `SIGNIFICANCE_LEVELS` was updated to include some more digits.
## Summary Closes elastic#165227. Removes configurable app targets. Only the standard logs app is registered (Note: [Infra is disabled in serverless](elastic#165289) observability / security projects currently). --------- Co-authored-by: Kibana Machine <[email protected]>
Updates the text for the info callouts which are displayed when anomaly detection jobs are waiting for a node. @szabosteve would you mind having a review of the text? **Jobs list**  **Creating a new job**  Fixes elastic#165472 --------- Co-authored-by: István Zoltán Szabó <[email protected]>
…lastic#167319) When exporting an anomaly detection job, it would be useful if the original `created_by` property was not removed from the job config. Related to elastic#167021 (comment) Related PR elastic#88898
`v88.3.0`⏩`v88.5.0` closes elastic#151514 --- ## [`88.5.0`](https://github.com/elastic/eui/tree/v88.5.0) - Updated `EuiCallOut` with a new `onDismiss` prop ([elastic#7156](elastic/eui#7156)) - Added a new `renderCustomToolbar` prop to `EuiDataGrid`, which allows custom rendering of the toolbar. ([elastic#7190](elastic/eui#7190)) - Added a new `allowResetButton` prop to `toolbarVisibility.showDisplaySelector` of `EuiDataGrid`, which allows hiding the "Reset to default" button from the display settings popover. ([elastic#7190](elastic/eui#7190)) - Added a new `additionalDisplaySettings` prop to `toolbarVisibility.showDisplaySelector` of `EuiDataGrid`, which allows rendering extra settings inside the display settings popover. ([elastic#7190](elastic/eui#7190)) - Updated `EuiDataGrid`'s toolbar display settings button icon ([elastic#7190](elastic/eui#7190)) - Updated `EuiTextTruncate` with significantly improved iteration performance. Removed `measurementRenderAPI` prop, as `EuiTextTruncation` now only uses more performant canvas render API ([elastic#7210](elastic/eui#7210)) - Updated `EuiPopover` with a new configurable `repositionToCrossAxis` prop ([elastic#7211](elastic/eui#7211)) - Updated `EuiDatePicker` to support `compressed` input styling ([elastic#7218](elastic/eui#7218)) - Added `gradient` and `palette` icon glyphs. ([elastic#7220](elastic/eui#7220)) **Bug fixes** - Fixed `EuiPopover`'s missing animations on popover close ([elastic#7211](elastic/eui#7211)) - Fixed `EuiInputPopover` anchoring to the wrong side and missing shadows on smaller screens ([elastic#7211](elastic/eui#7211)) - Fixed `EuiSuperDatePicker` icon spacing on the quick select button ([elastic#7217](elastic/eui#7217)) - Fixed a missing type in `EuiMarkdownEditor`'s default processing plugins ([elastic#7221](elastic/eui#7221)) ## [`88.4.1`](https://github.com/elastic/eui/tree/v88.4.1) **Bug fixes** - Fixed missing `className`s on `EuiTextTruncate` ([elastic#7212](elastic/eui#7212)) - Fixed `title`s on `EuiComboBox` dropdown options to always be present ([elastic#7212](elastic/eui#7212)) - Fixed `EuiComboBox` truncation issues when search is an empty space ([elastic#7212](elastic/eui#7212)) ## [`88.4.0`](https://github.com/elastic/eui/tree/v88.4.0) - Updated `EuiComboBox` to allow configuring text truncation behavior via `truncationProps`. These props can be set on the entire combobox as well as on on individual dropdown options. ([elastic#7028](elastic/eui#7028)) - Updated `EuiInMemoryTable` with a new `searchFormat` prop (defaults to `eql`). When setting this prop to `text`, the built-in search bar will ignore EQL syntax and allow searching for plain strings with special characters and symbols. ([elastic#7175](elastic/eui#7175)) **Bug fixes** - `EuiComboBox` now always shows the highlighted search text, even on truncated text ([elastic#7028](elastic/eui#7028)) - Fixed missing i18n in `EuiSearchBar`'s default placeholder and aria-label text ([elastic#7175](elastic/eui#7175)) - Fixed the inline compressed styles of `EuiDescriptionListTitle` to use a taller line-height for readability ([elastic#7185](elastic/eui#7185)) - Fixed `EuiComboBox` to correctly truncate selected items when displayed as pills and plain text ([elastic#7193](elastic/eui#7193)) **Accessibility** - Added `aria-current` attribute to `EuiTablePagination` ([elastic#7186](elastic/eui#7186)) **CSS-in-JS conversions** - Converted `EuiDroppable` and `EuiDraggable` to Emotion; Removed `$euiDragAndDropSpacing` Sass variables ([elastic#7187](elastic/eui#7187)) --------- Co-authored-by: Patryk Kopycinski <[email protected]> Co-authored-by: Jan Monschke <[email protected]> Co-authored-by: Thomas Watson <[email protected]>
…s_roles`, etc) to be overwritten via `yarn es serverless` command (elastic#167087) ## Summary ### `@kbn/es` package - Introduces `--resources` option to the `es serverless` command - Allows for [`serverless_resources`](https://github.com/elastic/kibana/tree/main/packages/kbn-es/src/serverless_resources) to be overwritten ### Security Solution Plugin - Added customized `users`, `users_roles` and `roles.yml` files that includes: - Updated `roles.yml` file (sync'ed with project controller version) - Updated `users` / `users_roles` file that includes one one per security project role (name the same as the role) - New CLI script - `node x-pack/plugins/security_solution/scripts/endpoint/start_es_serverless_with_security_users.js` - that will start ES in serverless mode and inject the customized `--resources` into the command - Any existing option that can be passed to `es` or `es serverless` can still continue to be passed to this new script. I will pass them along. closes elastic#167092 __
…167393) elastic/security-team#7588 To meet the above requirements, I believe it is sufficient to replace only the URL with one that directly points to the security integration instead of the integrations list. This change does not appear to affect the flow of guided onboarding in any way. https://github.com/elastic/kibana/assets/29123534/4d1aa943-2dce-4d43-bab1-d7cc024695f8
## Summary This PR removes the feature flag and enables the new index details page by default. The index details page was implemented in following PRs: - elastic#163521 - elastic#163955 - elastic#164741 - elastic#165027 - elastic#165038 - elastic#165456 In this PR we completely remove now obsolete code for the old index details flyout: react components and corresponding redux code. All related tests are updated and cleaned up. The config value for Index Management plugin `xpack.index_management.dev.enableIndexDetailsPage` is deprecated as unused and can be removed in v9.0. ### How to test 1. Start ES and Kibana with `yarn es snapshot` and `yarn start` 3. Navigate to Index Management and create an index 4. Click the index name in the table and check the tabs of the details page ### Screenshots #### Stateful Overview <img width="1387" alt="Screenshot 2023-09-27 at 14 41 57" src="https://github.com/elastic/kibana/assets/6585477/e58b15e7-d10c-4473-873c-d0f128392404"> Mappings <img width="1392" alt="Screenshot 2023-09-27 at 14 42 05" src="https://github.com/elastic/kibana/assets/6585477/441157cb-5a26-47c3-8da0-b4df51ebec5d"> Settings <img width="1385" alt="Screenshot 2023-09-27 at 14 42 13" src="https://github.com/elastic/kibana/assets/6585477/da66a2eb-1f21-44c1-9356-484c66caab88"> Statistics <img width="1380" alt="Screenshot 2023-09-27 at 14 42 22" src="https://github.com/elastic/kibana/assets/6585477/ec93d85c-e754-4c21-88ab-0124dc114fc9"> Error loading data <img width="1333" alt="Screenshot 2023-09-26 at 19 05 37" src="https://github.com/elastic/kibana/assets/6585477/fc1804b3-6aa0-4019-bae6-e7bb40113b28"> <img width="1327" alt="Screenshot 2023-09-26 at 19 06 07" src="https://github.com/elastic/kibana/assets/6585477/ca711697-cc74-4ba8-b17c-ec9b01f3026e"> <img width="1329" alt="Screenshot 2023-09-26 at 19 06 28" src="https://github.com/elastic/kibana/assets/6585477/0cb46b09-8542-452a-8845-40d060057e95"> <img width="1331" alt="Screenshot 2023-09-26 at 19 06 48" src="https://github.com/elastic/kibana/assets/6585477/87de8d3d-b6e5-4e8f-b27c-18a1c6e950d8"> Error saving index settings <img width="1332" alt="Screenshot 2023-09-26 at 19 07 31" src="https://github.com/elastic/kibana/assets/6585477/e6e4b3d0-c237-4d0a-995a-4562bc78f88e"> ### Serverless Overview <img width="1336" alt="Screenshot 2023-09-26 at 19 51 47" src="https://github.com/elastic/kibana/assets/6585477/6c76c23b-4be6-4ab3-ae1d-c7ae751e100d"> Mappings <img width="1336" alt="Screenshot 2023-09-26 at 19 23 51" src="https://github.com/elastic/kibana/assets/6585477/625fa703-506f-4389-9df0-86441a655074"> Settings <img width="1332" alt="Screenshot 2023-09-26 at 19 24 02" src="https://github.com/elastic/kibana/assets/6585477/c496ab09-f2db-4c1b-9fb6-1e9b64b1c142"> # Release note Index details can now be viewed on a new index details page in Index Management. <img width="1387" alt="Screenshot 2023-09-27 at 14 41 57" src="https://github.com/elastic/kibana/assets/6585477/b90c706d-8b15-49e4-8f6a-cb66f3ed1822"> --------- Co-authored-by: kibanamachine <[email protected]>
… rule details and API changes (elastic#165613) ## What this PR changes Follow up of elastic/pull/164107/ For serverless ES/Kibana, it gates exception list API for endpoint exceptions and restricts endpoint exceptions tab on Endpoint Security rule details based on project PLIs. If no endpoint PLIs, endpoint exceptions should not be accessible. - [x] Add upselling to `app/security/exceptions/details/endpoint_list` page - [ ] Tests (WIP) - in a follow up PR ### How to review Best to follow along commits for a code review. Below are details to manually test the changes. - Setup for _Servlerless_ - Run `yarn es serverless --kill --clean --license trial -E xpack.security.authc.api_key.enabled=true` on a terminal window to start ES. - Copy `config/serverless.security.yml` to `config/serverless.security.dev.yml` - Run `yarn serverless-security --no-base-path` on another terminal window to start kibana in serverless mode - Log in using `serverless_security` user. ### Tests (Serverless) This needs to be tested with a custom user/role and not `elastic_serverless` which has `superuser` role. 1. ### PLI configs `{ product_line: 'security', product_tier: 'essentials' }` or `{ product_line: 'security', product_tier: 'complete' }` and `{ product_line: 'endpoint', product_tier: 'essentials' }` or `{ product_line: 'endpoint', product_tier: 'complete' }` - #### UX 1. Navigate to Rules via `http://localhost:5601/app/security/rules/`. Click on `Add Elastic rules`. 2. Select and add `Endpoint Security` rule. 3. Click `Endpoint Security` and navigate to the rules details page, and you should see `Endpoint exceptions` tab. The tabs visible are `Alerts`, `Endpoint exceptions`, `Rule exceptions`, `Execution results`. 4. Navigate to Rules>Shared Exception Lists > Endpoint Security Exception List via `app/security/exceptions/details/endpoint_list` and you should be able to see the page with any added endpoint exceptions. - #### API requests (with user `serverless_security`) 1. should get a status `200` on`POST api/exception_lists/items` 2. should get a status `200` on `POST api/exception_lists/_export?id=endpoint_list&list_id=endpoint_list&namespace_type=agnostic&include_expired_exceptions=true` 3. should get a status `200` on `PUT api/exception_lists/items` 5. should get a status `200` on `DELETE api/exception_lists/items` 6. should get a status `200` on `GET api/exception_lists/items/_find?list_id=endpoint_list&namespace_type=agnostic` 2. ### PLI configs `{ product_line: 'security', product_tier: 'essentials' }` or `{ product_line: 'security', product_tier: 'complete' }` - #### UX 1. Navigate to Rules via `http://localhost:5601/app/security/rules/`. Click on `Add Elastic rules`. 2. Select and add `Endpoint Security` rule. 3. Click `Endpoint Security` and navigate to the rules details page, and you should not see `Endpoint exceptions` tab. The only tabs visible are `Alerts`, `Rule exceptions`, `Execution results`.  4. Navigate to Rules>Shared Exception Lists > Endpoint Security Exception List via `app/security/exceptions/details/endpoint_list` and you should see an upsell message.  - #### API requests 1. should get a status `403` on`POST api/exception_lists/items` 2. should get a status `403` on `POST api/exception_lists/_export?id=endpoint_list&list_id=endpoint_list&namespace_type=agnostic&include_expired_exceptions=true` 3. should get a status `403` on `PUT api/exception_lists/items` 6. should get a status `403` on `DELETE api/exception_lists/items` 7. should get a status `403` on `GET api/exception_lists/items/_find?list_id=endpoint_list&namespace_type=agnostic` --- **Flaky FTRs** https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3248 https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3255 ### Checklist - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [x] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <[email protected]>
Fixes JSDoc annotations for package `@kbn/ml-agg-utils`.
## Summary
Create utilities allowing to simulate a model version cohabitation
period, by creating two SO repositories of different versions so that
type/test owners can use it to assert the behavior of documents created
by one version and read by the other, or vice-versa.
### Usage example
```ts
describe('myIntegrationTest', () => {
const testbed = createModelVersionTestBed();
let testkit: ModelVersionTestKit;
beforeAll(async () => {
await testbed.startES();
});
afterAll(async () => {
await testbed.stopES();
});
beforeEach(async () => {
testkit = await testbed.prepareTestKit({
savedObjectDefinitions: [{
definition: mySoTypeDefinition,
modelVersionBefore: 1,
modelVersionAfter: 2,
}]
})
});
afterEach(async () => {
if(testkit) {
await testkit.tearsDown();
}
});
it('can be used to test model version cohabitation', async () => {
// last registered version is `1`
const repositoryV1 = testkit.repositoryBefore;
// last registered version is `2`
const repositoryV2 = testkit.repositoryAfter;
// do something with the two repositories, e.g
await repositoryV1.create(someAttrs, { id });
const v2docReadFromV1 = await repositoryV2.get('my-type', id);
expect(v2docReadFromV1.attributes).toEqual(something);
})
})
```
---------
Co-authored-by: kibanamachine <[email protected]>
… code generation (elastic#165091) **Part of: elastic/security-team#7491 ## Summary Migrated Detection Engine APIs to OpenAPI schema and code generation: - [x] `PUT /api/detection_engine/rules/prepackaged` - [x] `POST /api/detection_engine/rules/_export` - [x] `POST /api/detection_engine/rules/_import` - [x] `GET /api/detection_engine/tags` - [x] `GET /internal/detection_engine/rules/{ruleId}/execution/results`
…ggrega… (elastic#167305) ## Summary Closes elastic#161983 Adds telemetry for calculating global labels used in computing aggregation key for internal APM Metrics ## How to test Navigate to `internal/apm/debug-telemetry` on any of the deployed environments You will find the global_labels count field like this <img width="702" alt="image" src="https://github.com/elastic/kibana/assets/7416358/7ac85e42-259f-4750-ab85-5a1752a80099">
## Summary Fixes elastic#165083 Fixes elastic#165084 This PR - ensures that the input for field map is empty before adding the edited value - removes source index requirement for review and create step as that is not available in the test environment model flaky test runner build https://buildkite.com/elastic/kibana-flaky-test-suite-runner/builds/3267 ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### Risk Matrix Delete this section if it is not applicable to this PR. Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release. When forming the risk matrix, consider some of the following examples and how they may potentially impact the change: | Risk | Probability | Severity | Mitigation/Notes | |---------------------------|-------------|----------|-------------------------| | Multiple Spaces—unexpected behavior in non-default Kibana Space. | Low | High | Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces. | | Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. | High | Low | Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure. | | Code should gracefully handle cases when feature X or plugin Y are disabled. | Medium | High | Unit tests will verify that any feature flag or plugin combination still results in our service operational. | | [See more potential risk examples](https://github.com/elastic/kibana/blob/main/RISK_MATRIX.mdx) | ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
…in ML pages and Transforms management (elastic#166668) Co-authored-by: kibanamachine <[email protected]>
fixes elastic#166691 ## before <img width="1790" alt="Screenshot 2023-09-25 at 21 12 45" src="https://github.com/elastic/kibana/assets/3369346/ea6bd1a4-9d76-4a92-800e-400b86e8c5fc"> ## after <img width="1790" alt="Screenshot 2023-09-25 at 21 13 03" src="https://github.com/elastic/kibana/assets/3369346/3d3f1ea4-1894-45a6-bdad-88cb40ce077f"> ### Responsiveness https://github.com/elastic/kibana/assets/3369346/b226e31e-12c0-4634-83e3-96e23ce95280 --------- Co-authored-by: Yngrid Coello <[email protected]>
…67733) ## Summary As part of this [PR](elastic#167623), added a logic to handle hiding of Logs Panels which was consuming a lot of memory. With [Cypress Upgrade](elastic#162383) to 13.x, this issue is now fixed and hence this can be reverted. ## How to be sure this works ? If the PR passes the build, you know it works
New setting was added to go back to use the old one: <img width="1005" alt="Screenshot 2023-09-28 at 10 03 08" src="https://github.com/elastic/kibana/assets/55978943/051931d6-01f5-4a33-81a4-41e3f6dd047b"> In the old API, some logic was still being handled by kibana to create the flamegraph data. This logic was moved to the Profiling ES plugin and a new API was created: `_profiling/flamegraph`. We've proven that this has improved the loading time to render the profiling in ~3s. --------- Co-authored-by: Kibana Machine <[email protected]>
[](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@elastic/charts](https://togithub.com/elastic/elastic-charts) | [`59.1.0` -> `60.0.0`](https://renovatebot.com/diffs/npm/@elastic%2fcharts/59.1.0/60.0.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>elastic/elastic-charts (@&elastic#8203;elastic/charts)</summary> ### [`v60.0.0`](https://togithub.com/elastic/elastic-charts/blob/HEAD/CHANGELOG.md#6000-2023-09-20) [Compare Source](https://togithub.com/elastic/elastic-charts/compare/v59.1.0...v60.0.0) ##### Bug Fixes - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to ^88.2.0 ([#&elastic#8203;2161](https://togithub.com/elastic/elastic-charts/issues/2161)) ([6609a19](https://togithub.com/elastic/elastic-charts/commit/6609a19231ef8503a7cd467b1fca23c4528d6a32)) - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to ^88.3.0 ([#&elastic#8203;2163](https://togithub.com/elastic/elastic-charts/issues/2163)) ([624f43a](https://togithub.com/elastic/elastic-charts/commit/624f43a0f8cffffc6622bd9c3f65a3f43af40b08)) - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to v85 ([#&elastic#8203;2113](https://togithub.com/elastic/elastic-charts/issues/2113)) ([1b3fa7c](https://togithub.com/elastic/elastic-charts/commit/1b3fa7c34a96d38117cef6e1214757795b57dcd3)) - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to v87 ([#&elastic#8203;2145](https://togithub.com/elastic/elastic-charts/issues/2145)) ([312c32c](https://togithub.com/elastic/elastic-charts/commit/312c32cb71cb13ce0b92c86e77c3a975e426fd2b)) - **deps:** update dependency [@&elastic#8203;elastic/eui](https://togithub.com/elastic/eui) to v88 ([#&elastic#8203;2154](https://togithub.com/elastic/elastic-charts/issues/2154)) ([4070da0](https://togithub.com/elastic/elastic-charts/commit/4070da0c1f152009cd3a62abf314f6cb9f711845)) - **tooltip:** rendering in react v18 ([#&elastic#8203;2169](https://togithub.com/elastic/elastic-charts/issues/2169)) ([f30df54](https://togithub.com/elastic/elastic-charts/commit/f30df5444f0a1938b27c08acf6a15f4fc748d4ea)) - update font family ([#&elastic#8203;2165](https://togithub.com/elastic/elastic-charts/issues/2165)) ([be07b0c](https://togithub.com/elastic/elastic-charts/commit/be07b0c2164fc0a8784eb2550ad7495ed585bcdf)) - **waffle:** remove alpha artifacts ([#&elastic#8203;2139](https://togithub.com/elastic/elastic-charts/issues/2139)) ([8eb4ede](https://togithub.com/elastic/elastic-charts/commit/8eb4edecf87e9eabfeb01b1138533c5d20dcab2a)) - Wait a tick before reporting render status ([#&elastic#8203;2131](https://togithub.com/elastic/elastic-charts/issues/2131)) ([fd2bca4](https://togithub.com/elastic/elastic-charts/commit/fd2bca4ee25f7a99eafc4e2af3c312dc9183e49b)) - **xy:** disable legend extra on ordinal ([#&elastic#8203;2114](https://togithub.com/elastic/elastic-charts/issues/2114)) ([3ddfb18](https://togithub.com/elastic/elastic-charts/commit/3ddfb1816b82522e16d23b5c5230772eb5d3bd69)) ##### Features - add locale prop to Settings ([#&elastic#8203;2164](https://togithub.com/elastic/elastic-charts/issues/2164)) ([0bb3ab1](https://togithub.com/elastic/elastic-charts/commit/0bb3ab1f3afc0a04c7e1af2418c6fa0a3bdd1af4)) ##### BREAKING CHANGES - **xy:** when using the `ScaleType.Ordinal` for the X scale the legend extra value, representing the last and current hovered value, will not be shown. </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/elastic/kibana). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ny4xIiwidXBkYXRlZEluVmVyIjoiMzYuOTcuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Marco Vettorello <[email protected]> Co-authored-by: Stratoula Kalafateli <[email protected]> Co-authored-by: Drew Tate <[email protected]>
…elastic#167627) ## Summary fixes elastic#164013 The API does not return uninstall token for the policy id `policy-elastic-agent-on-cloud` ### questions - should it omit uninstall tokens for other `managed` policies, too? - or should we not generate uninstall tokens for `managed` policies at all?
…sted when cloning (elastic#167584) ## Summary Fixes elastic#164696 This PR ensures that the `Destination index same as job ID` state is persisted when switching between steps for original jobs and cloned jobs. https://github.com/elastic/kibana/assets/6446462/adb1cbcf-3387-4467-bbf9-666388e3145d ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers)
) ## Summary The recent [change](elastic#167410) broke an integration test in agent where the test upgrades to a newer snapshot version. This change is removing the version check against the latest agent version if `versionToUpgrade` is given. ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…e in-app docs (elastic#167638) issue: elastic#166717 original PR: elastic#166741 ## Summary General * Add the "How is risk score calculated?" button to the entity analytics dashboard and risk score tab on the Host/User page. * ~Add risk score hover action to the user/host overview component.~ Add a tooltip with link to risk score external doc. * Update risk score in-app doc * Update the field name “classification” to “level” everywhere the risk score is displayed * Update the “tech preview” label to “beta” everywhere the risk score is displayed * Rename Learn More to "How is host/user risk score calculated?" and link to External Docs * Add Beta tag to the settings page EA Dashboard: (User and Host) * Retain panel tooltip - Remove “Tech Preview” * Learn more link -> In Product flyout * Learn More (in Flyout) -> Add link to external docs page * Remove the tooltip from *Risk Classification column Alert Page -> Insights: * Change Tooltip on *Classification field -> How is Risk Score Calculated link Host/User Pages-> Risk Score Tab * Retain panel tool-tip * Add "How is Risk Score Calculated" similar to Dashboard * Remove tooltip from "Risk Classification" column Host/User Details: * Change Tooltip on "Classification field -> How is Risk Score Calculated link * Move score over time "learn more" link to the table header * Don't show the dashboard link when risk engine is enabled. ### Checklist Delete any items that are not applicable to this PR. - [x] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
…lastic#167770) ## Summary ### Release note Self managed Search connectors now show advanced configuration in UI. <img width="1072" alt="Screenshot 2023-10-02 at 13 07 57" src="https://github.com/elastic/kibana/assets/1410658/ddaa5d25-3159-4bc0-8b0b-83daa2b408c1"> <img width="1062" alt="Screenshot 2023-10-02 at 13 08 12" src="https://github.com/elastic/kibana/assets/1410658/f3c70c20-5a70-42e8-9e7c-de90b77b0c3c"> ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios Co-authored-by: Kibana Machine <[email protected]>
…lastic#167409) Closes elastic#166009. When system integration is installed successfully we should be able to redirect the user to logs explorer with the `System integration` selected https://github.com/elastic/kibana/assets/1313018/7a1d7457-00e8-4399-9332-3ea7af2b0145 When system integration installation failed we should be able to redirect the user to logs explorer with `All logs` selected https://github.com/elastic/kibana/assets/1313018/e13f69ab-adb4-460c-84cf-d9971ce56b9f When system integration is being installed, Explore Logs button should be disabled https://github.com/elastic/kibana/assets/1313018/5dd04859-e75b-49ed-9f47-5ad2120eb9d8 ### How to test 1. Log in as `viewer` user 2. Enter [system logs](https://deploy-kibana-pr167409.kb.us-west2.gcp.elastic-cloud.com/app/observabilityOnboarding/systemLogs) onboarding flow 3. Verify System integration was not installed 4. Click on `Explore Logs` 5. Verify you are being redirected to Log explorer with `All logs` being selected 6. Logout and log in again as `admin` user 7. Enter [system logs](https://deploy-kibana-pr167409.kb.us-west2.gcp.elastic-cloud.com/app/observabilityOnboarding/systemLogs) onboarding flow 8. Verify system integration was installed successfully 9. Click on `Explore Logs` 10. Verify you are being redirected to Log explorer with `[system]` being selected
…tic#167644) ## Summary Revert the revert for elastic#166942 💪🏻 Fixes elastic#165569 Fixes elastic#166617 Fixes elastic#166618 Fixes elastic#166619 Fixes elastic#166620
Verified by running `npm test`.
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers