Swap empty with explicit string comparison.

michael-rubel · Oct 4, 2023 · f3accdd · f3accdd
1 parent 7eb268e
commit f3accdd
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 5 deletions.
diff --git a/src/Artisan/stubs/value-object.stub b/src/Artisan/stubs/value-object.stub
@@ -67,7 +67,7 @@ class {{ class }} extends ValueObject
     {
         // TODO: Implement validate() method.
 
-        if (empty($this->value())) {
+        if ($this->value() === '') {
             throw ValidationException::withMessages(['Value of {{ class }} cannot be empty.']);
         }
     }

diff --git a/src/Collection/Complex/ClassString.php b/src/Collection/Complex/ClassString.php
@@ -114,7 +114,7 @@ public function value(): string
      */
     protected function validate(): void
     {
-        if (empty($this->value())) {
+        if ($this->value() === '') {
             throw ValidationException::withMessages(['Class string cannot be empty.']);
         }
     }

diff --git a/src/Collection/Complex/FullName.php b/src/Collection/Complex/FullName.php
@@ -102,7 +102,7 @@ public function toArray(): array
      */
     protected function validate(): void
     {
-        if (empty($this->value())) {
+        if ($this->value() === '') {
             throw ValidationException::withMessages(['Full name cannot be empty.']);
         }
 

diff --git a/src/Collection/Complex/TaxNumber.php b/src/Collection/Complex/TaxNumber.php
@@ -141,7 +141,7 @@ public function toArray(): array
      */
     protected function validate(): void
     {
-        if (empty($this->value())) {
+        if ($this->value() === '') {
             throw ValidationException::withMessages(['Tax number cannot be empty.']);
         }
     }

diff --git a/src/Collection/Primitive/Text.php b/src/Collection/Primitive/Text.php
@@ -74,7 +74,7 @@ public function value(): string
      */
     protected function validate(): void
     {
-        if (empty($this->value())) {
+        if ($this->value() === '') {
             throw new InvalidArgumentException('Text cannot be empty.');
         }
     }