Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rails 4.2 failing specs #69

Closed
wants to merge 1 commit into from
Closed

Conversation

jlurena
Copy link
Collaborator

@jlurena jlurena commented Jul 8, 2024

No description provided.

@mhgbrown
Copy link
Owner

mhgbrown commented Jul 8, 2024

I think what's causing the root of the problem is that setting concurrent_write doesn't re-require concurrent/promise and that's necessary for certain Ruby/Rails/whatever combinations. It looks like the only chance for it to get required is during setup. After requiring concurrent/promise explicitly in the spec helper, the build passes.

Does that sound right? I can look into ensuring that changing concurrent_write will require concurrent/promise

@jlurena
Copy link
Collaborator Author

jlurena commented Jul 8, 2024

Ah nice. Thanks..it's hard for me to test as I can't install ruby < 2.7 in my machine

@mhgbrown
Copy link
Owner

mhgbrown commented Jul 9, 2024

Got it, I'll get something going.

@mhgbrown
Copy link
Owner

mhgbrown commented Jul 9, 2024

Should we close this in favor of #70?

@jlurena
Copy link
Collaborator Author

jlurena commented Jul 9, 2024

Yeah

@jlurena jlurena closed this Jul 9, 2024
@jlurena jlurena deleted the ISSUE-66 branch July 9, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants