hash long cache keys #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/cached_resource/caching.rb
Outdated
| @@ -112,7 +112,10 @@ def cache_clear | |||
|
|
|||
| # Generate the request cache key. | |||
| def cache_key(*arguments) | |||
| "#{name.parameterize.gsub("-", "/")}/#{arguments.join('/')}".downcase.delete(' ') | |||
| arguments_string = arguments.join('/') | |||
| arguments_key = arguments_string.length > 150 ? Digest::SHA2.hexdigest(arguments_string) : arguments_string | |||
There was a problem hiding this comment.
Could you constantize this "150" somewhere?
|
Also would appreciate if you could create a test for this |
|
@Adrian2112 could you bump the version for this change? travis.yml have been updated and we should re-run your test. |
Adrian2112
force-pushed
the
long_cache_key
branch
from
a4821b0 to
64e4b4a
Compare
|
I just rebased agains master. Does that work? |
|
Could this be optional? Setup a configuration variable for it. Just wondering the use case and would everyone want to have hashed keys. |
|
Closing for #72 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some cache stores have a size limit for the keys. E.g ActiveSupport::Cache::FileStore
So in case there are a lot of parameters and the cache key is too long we hash it