This repository has been archived by the owner on May 31, 2020. It is now read-only.
Support additional options for broker and backend #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mher
added a commit
that referenced
this pull request
Mar 19, 2017
|
Would be great to get a release out with these changes |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for more flexible options to the broker and backend.
I needed to use TLS connection to Redis, which this PR makes possible. I tried my best to support all the existing options, to make it backwards compatible.
This also contains a bit of cleanup, and removes some duplication and makes it more consistent.
In addition this should also better handle most changes done in #82, except the changes to durability at https://github.com/mher/node-celery/pull/82/files#diff-fdee2594199f6ae99c831f6bf51c5c5fR182.
It also contains the changes in #81.