Skip to content

Commit

Permalink
Update firebase deploy script to latest from firebase CLI
Browse files Browse the repository at this point in the history
Generated with firebase init hosting:github

I'm hoping this will fix my errors with pull requests not having access to the
secret key, maybe? But I don't know how it would. I'm just ruling it out at
this stage that there's no fix by updating.
  • Loading branch information
mhansen committed Apr 10, 2024
1 parent 842b4ae commit 5a3b24f
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/firebase-hosting-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,3 @@ jobs:
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_NZWIRELESSMAP_FIREBASE }}'
channelId: live
projectId: nzwirelessmap-firebase
env:
FIREBASE_CLI_PREVIEWS: hostingchannels
7 changes: 5 additions & 2 deletions .github/workflows/firebase-hosting-pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,13 @@

name: Deploy to Firebase Hosting on PR
'on': pull_request
permissions:
checks: write
contents: read
pull-requests: write
jobs:
build_and_preview:
if: '${{ github.event.pull_request.head.repo.full_name == github.repository }}'
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
Expand All @@ -15,5 +20,3 @@ jobs:
repoToken: '${{ secrets.GITHUB_TOKEN }}'
firebaseServiceAccount: '${{ secrets.FIREBASE_SERVICE_ACCOUNT_NZWIRELESSMAP_FIREBASE }}'
projectId: nzwirelessmap-firebase
env:
FIREBASE_CLI_PREVIEWS: hostingchannels

0 comments on commit 5a3b24f

Please sign in to comment.