Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating MANIFEST.in to include maskclip bpe vocab file. #63

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

opipari
Copy link

@opipari opipari commented Jun 28, 2024

Description

When installing the package using setuptools and pip, the vocabulary file required by maskclip (bpe_simple_vocab_16e6.txt.gz) is not included in the distribution package since it's not specified in the manifest file. This issue was also raised and described in #47. Trying to use the maskclip model after installing FeatUp currently results in a FileNotFoundError error for the missing vocabulary file.

Solution

This pull request makes three modifications to resolve the installation:

  1. Specify the vocabulary file as one to be installed along with python source files by listing bpe_simple_vocab_16e6.txt.gz in the MANIFEST.in file. [Link to line]
  2. Renaming manifest.in to MANIFEST.in so it is used by setuptools during the installation process.
  3. Setting the include_package_data flag to True within setup.py to ensure the manifest is used and the vocab file is installed. [Link to line]

Thanks

Thanks for considering this pull request and this awesome project!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant