Updating MANIFEST.in to include maskclip bpe vocab file. #63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When installing the package using setuptools and pip, the vocabulary file required by maskclip (bpe_simple_vocab_16e6.txt.gz) is not included in the distribution package since it's not specified in the manifest file. This issue was also raised and described in #47. Trying to use the maskclip model after installing FeatUp currently results in a
FileNotFoundError
error for the missing vocabulary file.Solution
This pull request makes three modifications to resolve the installation:
bpe_simple_vocab_16e6.txt.gz
in theMANIFEST.in
file. [Link to line]manifest.in
toMANIFEST.in
so it is used by setuptools during the installation process.include_package_data
flag toTrue
within setup.py to ensure the manifest is used and the vocab file is installed. [Link to line]Thanks
Thanks for considering this pull request and this awesome project!