Fixed test for logistic regression, slope 1. #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks fail with the following log: ``` 1) test: LogisticRegressionTest::test_logistic_regression (F) line: 103 tests/logistic_regression_test.cpp assertion failed - Expression: abs(coeffs.at(1)-0.49)<0.01 - Example 2: Slope1 term doesn't match ``` According to the documentation the expected value for slope 1 is `-0.49` and the test should thus have the opposite sign.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks fail with the following log:
According to the documentation the expected value for slope 1 is
-0.49and the test should thus have the opposite sign.