Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Epic alignment changes #41

Merged
merged 37 commits into from
Sep 7, 2014
Merged

Epic alignment changes #41

merged 37 commits into from
Sep 7, 2014

Conversation

mgymrek
Copy link
Owner

@mgymrek mgymrek commented Sep 7, 2014

Highlights of the changes:

  • For alignment, we align to all STR regions at once, rather than only to the regions with STRs of specific motif. To accommodate this, the index structure has changed (and decreased in size significantly). I added a message to warn anyone trying to use the old index with the new version.
  • Since we no longer need to detect what the repeat motif is, I have removed the FFTW dependency. This resulted in deleting tons of code from the detection step.
  • I also cleaned up/got rid of a lot of code that is no longer being used. Still need to go through and correct what compiler warnings remain and add coverage tests (besides the ones from third party software).

Results:

  • Alignment is now much more sensitive, aligning something like 60% more reads.
  • Speed is similar to what it was with the new alignment speedups added a couple months ago. I need to do some more tests for this.
  • Memory usage is ~half what it used to be due to the smaller index.
  • At least on the one Mac I tested, it compiled very nicely and all checks except multithreading worked, thanks to the awesomeness of Gordy.

mgymrek added 30 commits March 13, 2014 16:20
mgymrek pushed a commit that referenced this pull request Sep 7, 2014
@mgymrek mgymrek merged commit aebc7dd into master Sep 7, 2014
@mgymrek mgymrek deleted the epic-alignment-changes branch September 7, 2014 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant