Update smart_repair.py #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(1) Added code to detect and handle an unusual configuration of polygons around a gap that wasn't covered before; (2) Added the ability for the user to control the precision of the grid to snap coordinates to; (3) Added a check/fix for empty geometries.
Incorporate changes from pull request #91. New function is called "make_valid_polygons" rather than "make_valid" to avoid conflict with Shapely's make_valid function, and default value for force_polygons has been set to True. Default value for force_polygons in autorepair/quick_repair is still set to False and make_valid is used throughout by default; if force_polygons is set to True, then make_valid_polygons is used throughout instead of make_valid.
Restored some force_polygons options that I shouldn't have deleted before.
peterrrock2
approved these changes
Dec 22, 2023
There was a problem hiding this comment.
This all looks good! Note for documentation / credit: used some of the code created by @coreyryanhanson in a previous version of Maup to fix some of the issues caused by line segments. See documentation in PR#91
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(1) Added code to detect and handle an unusual configuration of polygons around a gap that wasn't covered before;
(2) Added the ability for the user to control the precision of the grid to snap coordinates to;
(3) Added a check/fix for empty geometries.