add new arguments #96
Conversation
Add a rank_cols argument to load_csv so that the user can specify which columns of the csv correspond to rankings. Helpful, for example, with the 2013 Minneapolis data file on MGGG/chicago which has extraneous columns. Also removed quota parameter from Election.get_threshold method since quota should be an attribute of the Election.
|
Hi @cdonnay, A couple of notes:
I'll let someone else comment on the self.quota issue as I haven't kept up with the API in that level of detail. |
Thanks, @jamesturk ! I added .idea to .gitignore, and gave the `rank_cols` a default argument. I think it's worth discussing whether or not you actually want the `rank_cols` parameter to have a default argument. My argument for not including a default is that we don't want to force preprocessing of the csv file onto the user, and we want the user to think intentionally about loading in their data. Happy to hear other ideas about why we might want a default.
Default needs to be a list since that is the declared data type.
Fixing a line that was too long for test.
Use .lower() method to allow users to input quotas.
|
Thanks, @jamesturk ! I added .idea to .gitignore, and gave the I think it's worth discussing whether or not you actually want the |
|
Hi @cdonnay thanks for helping with Votekit! I agree with James on making rank_cols an optional argument - I think the user should have an idea of what their data looks like before loading it, but it would be annoying for them to specify the rank_cols every time if their csv file is already clean without extraneous columns. A default would save them this trouble. |
|
Awesome, sounds good to me. |
| @@ -61,20 +61,18 @@ def __init__( | |||
| self.transfer = transfer | |||
| self.seats = seats | |||
| self.tiebreak = tiebreak | |||
| self.threshold = self.get_threshold(quota) | |||
| self.quota = quota.lower() | |||
| @@ -55,6 +59,12 @@ def load_csv( | |||
| if id_col is not None and not df.iloc[:, id_col].is_unique: | |||
| raise DataError(f"Duplicate value(s) in column at index {id_col}") | |||
|
|
|||
| if rank_cols: | |||
| @@ -5,4 +5,4 @@ htmlcov/ | |||
| .DS_Store | |||
| dist/ | |||
| .ipynb_checkpoints | |||
|
|
|||
| .idea | |||
There was a problem hiding this comment.
you may need to delete the .idea and inspectionProfiles files from the version of your repo on github, but then the .gitignore should handle them in the future!
There was a problem hiding this comment.
Okay, I think I just deleted those files.
Add a
rank_colsargument toload_csvso that the user can specify which columns of the csv correspond to rankings. Helpful, for example, with the 2013 Minneapolis data file on MGGG/chicago which has extraneous columns.Also removed
quotaparameter fromElection.get_thresholdmethod sincequotashould be an attribute of the Election.Also, this is my first pull request; Moon has asked me to tag y'all going forward. Let me know if you don't wish to be tagged or if I made an error in my request. Thanks!
@jamesturk @drdeford @jgibson517 @ziglaser @jennjwang