Generalized IC/IAC - Ballot Simplex #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking for review on ballot generator refactoring (can disregard the ballot simplex class) The goal is allow users to initialize a Ballot Generator in two ways. 1) to provide a set of parameters including alpha, cohesion factor and construct a preference interval (this is the from_paeans method) 2) to specify the preference interval and bloc to voter proportion directly. Since python does not allow overloading, I'd like feedback on how to implement both types of parameterization |
jgibson517
reviewed
Aug 29, 2023
jgibson517
reviewed
Aug 29, 2023
| @@ -422,185 +445,6 @@ def group_elements_by_mapping(element_list, mapping): | |||
| ) | |||
|
|
|||
|
|
|||
| # def test_Cambridge_distribution(): | |||
There was a problem hiding this comment.
also looks like you overwrote some of the tweaks Zach and i made to make the cambridge test pass consistently, unless you two redid it after I left. looks like it was this in this commit: 798fef5
jamesturk
reviewed
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.