rewrite Qt library frontend #2570
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
endrift
requested changes
Jun 29, 2022
endrift
requested changes
Jun 30, 2022
|
Unsure it's related, but I got this warning when testing: |
endrift
reviewed
Jul 2, 2022
endrift
requested changes
Jul 2, 2022
It's related. Checking, I see it too. Haven't pinpointed it yet. I'll hook up QAbstractItemModelTester and see if it sheds light on it. |
ahigerd
commented
Jul 2, 2022
|
Rebased in order to pick up the platform icons. |
|
Possible addition: https://github.com/ahigerd/mgba/pull/1/files I don't know if this is a good idea or not, so I'm keeping it separate until it can be reviewed. |
endrift
requested changes
Jul 4, 2022
|
Oops. Forgot to add the new icons to the qrc. |
|
Can you rebase this on current master? |
ahigerd
force-pushed
the
alh/library
branch
2 times, most recently
from
a35d44f
to
8e484ac
Compare
ahigerd
force-pushed
the
alh/library
branch
2 times, most recently
from
964b303
to
93bf6d2
Compare
endrift
requested changes
Apr 13, 2023
ahigerd
force-pushed
the
alh/library
branch
3 times, most recently
from
318ccb2
to
e4cc3c2
Compare
|
Please rebase |
endrift
reviewed
May 22, 2023
ahigerd
commented
Nov 20, 2023
ahigerd
force-pushed
the
alh/library
branch
2 times, most recently
from
b437064
to
f415084
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've ripped out the existing implementation for the Qt library frontend and replaced it with a QAbstractItemModel. This should improve performance significantly. I've added some additional functionality along the way, like some reasonable behavior on window resizing and storing view configuration in the settings.
The grid view isn't implemented yet, obviously (but it wasn't available for selection in the settings, either), and I haven't removed LibraryGrid from the repository for future reference.