Add support for extra-chroms (string chromosomes) #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignoring cmake generated files
parse_chr was identical to parse_string. Now we read text using the same parse_str function
testing with X and Contig123456 chromosomes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear @mfranberg ,
I found some time to try to change how your library read chromosomes in order to support string chromosome. I've changed code and tests accordingly and seems to me that I can read my string chromosomes properly. I've also updated the README section, since it seems to me it was a little outdated.
If you could revise this changes and give me a feedback, will be very helpful.
This PR will close #29