feat: use kitty image protocol in ghostty #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
|
Hmm interesting... I'll have to wait until it's publicly available then :(. Thanks for trying it out! |
|
@mfontanini it's out now 😄 |
|
Looks like this was working already, merging! |
mfontanini
force-pushed
the
feat/ghostty-images
branch
from
2220ce4 to
37d71a9
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
Your initial command you posted a while back is just doing an install without this specific branch so this wouldn't have worked. Did you just install the latest from the master branch? Make sure you reinstall if you have it installed already. But yes, images work as expected on ghostty for me. |
|
@mfontanini I just realized my mistake earlier, went to build off It's all good (sorry for the noise): 
Many thanks for your hard work on presenterm! ❤️ |
|
Awesome, thanks for verifying! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This detects ghostty and uses the kitty graphics protocol on it by default. I don't have access to ghostty yet so I can't test this but based on this article
TERM_PROGRAM=ghosttyis the way to detect this. If it implements the protocol correctly, this should work out of the box.@fredrikaverpil could I ask for your help here? :)