Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update notebooks #252

Merged
merged 6 commits into from
Oct 5, 2024
Merged

Update notebooks #252

merged 6 commits into from
Oct 5, 2024

Conversation

justinlaughlin
Copy link
Contributor

  • Update from Binder -> Colab for ex1 and ex9 (Colab notebooks seem to work much faster/more consistently than the Binder notebooks)
  • Small changes reflecting updates to pyglvis
  • These changes have been tested in the pyglvis repo (see badges in the README of https://github.com/GLVis/pyglvis)

tzanio
tzanio approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@tzanio tzanio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @justinlaughlin !

sshiraiwa
sshiraiwa approved these changes Oct 5, 2024
View reviewed changes
Copy link
Member

@sshiraiwa sshiraiwa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. This looks great!

@sshiraiwa
Copy link
Member

Merging this. I am aware that we still have an issue with current master due to very recent changes in C++,
which will be fixed in different PR

@sshiraiwa sshiraiwa merged commit d28a986 into master Oct 5, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshiraiwa sshiraiwa sshiraiwa approved these changes

@tzanio tzanio tzanio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@justinlaughlin @sshiraiwa @tzanio