-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: map feature toggle #994
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if I was supposed to be reviewing this or not. But so far haven't found anything!
The recent changes were to fix a bug where the swipeable area on mobile wasn't always sticky to the top |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐺 speedy swipey fix
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found!
This PR addresses bloom-housing#4507
Description
Adds back in the old map files, postfixed with
Deprecated
.Adds a new dynamic feature toggle to turn the map experience on / off.
On desktop:
Keeps the UI changes from the new map to have a full screen and new search bar, but uses the old map / only fetches 25 listings
On mobile:
Reverts back to the swipe-up experience, but keeps the full screen map and the new search bar.
Additionally, when the toggle is on, fixes a bug where externally fetched listings weren't showing in info modals after clicking on a pin.
How Can This Be Tested/Reviewed?
With
SHOW_ALL_MAP_PINS
as false, compare the listings map experience to prod. We will have the full screen maps and placement of the search bar, but the rest should be very similar.There's lots of lines added from copying and pasting the old files. These
Deprecated
files have no changes to just a line or two to support toggling. The files were already messy, so I wouldn't focus time there since we're moving away from that version.Author Checklist:
yarn generate:client
and/or created a migration when requiredReview Process: