Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle copying app methods (#4491) #960

Merged
merged 1 commit into from
Nov 25, 2024
Merged

Conversation

ColinBuyck
Copy link
Collaborator

This PR addresses bloom-housing#4490

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR updates the duplicate function in the listing service to transform the application methods array to how the listing create function expects it.

How Can This Be Tested/Reviewed?

Test copying a listing with no paper app, paper app selected but not uploaded, one paper app, multiple paper apps... and ensure that the listing and assets are copied over without error.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

* fix: handle copying app methods

* fix: remove unrelated changes
@emilyjablonski emilyjablonski added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Nov 25, 2024
@ColinBuyck ColinBuyck merged commit c90836d into main Nov 25, 2024
16 checks passed
@ColinBuyck ColinBuyck deleted the 4490/copy-paper-app branch November 25, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants