Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to HTML text inputs with numeric validation #666

Closed
wants to merge 1 commit into from

Conversation

jaredcwhite
Copy link
Collaborator

This PR addresses #658

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

The working theory is the issue with numbers changing randomly in the unit editing is due to input type="number" weirdness around mouse/trackpad scrolling. This PR switches to input type="text" and uses React Hook Form validation to verify integer input.

How Can This Be Tested/Reviewed?

Try editing units for a listing, income, or the miles radius on preferences.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@emilyjablonski
Copy link
Collaborator

Should this be a core change?

@jaredcwhite
Copy link
Collaborator Author

@emilyjablonski I agree this should be fixed in Core first, so I've opened up a new PR there. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants