Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: include preference address (#4537) #1047

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mcgarrye
Copy link
Collaborator

This PR addresses #(4536)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

For preferences that required an address to be input, they were appearing for the application export but not for the lottery export. This adjustment allows it to work correctly for both.

How Can This Be Tested/Reviewed?

On the partner site, create/update a listing to be a lottery listing with a preference that requires/allows for an address to be input.
Submit an application for the listing, claim the preference and include an address.
Export applications and verify the preference and preference address appear correctly.
Close the listing, run the lottery, export the lottery, and verify the preference and preference address appear correctly.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@mcgarrye mcgarrye added 1 review needed release A PR that is pulling over a commit(s) from core labels Jan 14, 2025
@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jan 14, 2025
@mcgarrye mcgarrye merged commit d8e2bb0 into main Jan 15, 2025
16 checks passed
@mcgarrye mcgarrye deleted the release/preference-address-lottery-export branch January 15, 2025 15:14
@mcgarrye mcgarrye removed the ready to merge Should be applied when a PR has been reviewed and approved label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release A PR that is pulling over a commit(s) from core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants