Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: always deploy internal api #1033

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix: always deploy internal api #1033

merged 1 commit into from
Jan 3, 2025

Conversation

gbbayareametro
Copy link

@gbbayareametro gbbayareametro commented Jan 3, 2025

This PR addresses #(insert-number-here)

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

Please include a summary of the change and which issue(s) is addressed.

How Can This Be Tested/Reviewed?

Provide instructions so we can review, including any needed configuration, and the test cases that need to be QAd.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📟

@ludtkemorgan ludtkemorgan added the ready to merge Should be applied when a PR has been reviewed and approved label Jan 3, 2025
@gbbayareametro gbbayareametro merged commit f591b30 into main Jan 3, 2025
16 checks passed
@gbbayareametro gbbayareametro deleted the fix/buildfix branch January 3, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants