Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remap household member relationships #1028

Merged
merged 4 commits into from
Jan 2, 2025

Conversation

emilyjablonski
Copy link
Collaborator

@emilyjablonski emilyjablonski commented Jan 2, 2025

This PR addresses #1022

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

We need to turn autofill back on after this is merged.

Description

Re-maps household member relationships after changing the values.

How Can This Be Tested/Reviewed?

I tested this locally by ensuring I had a local application with an old value and then running the script.

The updated mapping is at the bottom of this document: https://docs.google.com/document/d/19URmYULqr351SnlOwh7BGVW5Qw9uGfdXHoy69zaqulA/edit?tab=t.0

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@emilyjablonski emilyjablonski marked this pull request as ready for review January 2, 2025 17:04
Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worked great!

@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jan 2, 2025
@emilyjablonski emilyjablonski merged commit fd460c0 into main Jan 2, 2025
16 checks passed
@emilyjablonski emilyjablonski deleted the 1022/household-member-relationships branch January 2, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants