Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: listing opportunity email content updates #1021

Merged
merged 6 commits into from
Jan 7, 2025

Conversation

jaredcwhite
Copy link
Collaborator

@jaredcwhite jaredcwhite commented Dec 19, 2024

This PR addresses #995

  • Addresses the issue in full
  • Addresses only certain aspects of the issue

Description

This PR updates the listing opportunity email with some copy changes/additions as well as showing the time for dates (like Application Due Date).

How Can This Be Tested/Reviewed?

I'm not sure how to trigger the email being sent out manually.

Author Checklist:

  • Added QA notes to the issue with applicable URLs
  • Reviewed in a desktop view
  • Reviewed in a mobile view
  • Reviewed considering accessibility
  • Added tests covering the changes
  • Made corresponding changes to the documentation
  • Ran yarn generate:client and/or created a migration when required

Review Process:

  • Read and understand the issue
  • Ensure the author has added QA notes
  • Review the code itself from a style point of view
  • Pull the changes down locally and test that the acceptance criteria is met
  • Either (1) explicitly ask a clarifying question, (2) request changes, or (3) approve the PR, even if there are very small remaining changes, if you don't need to re-review after the updates

@jaredcwhite jaredcwhite changed the title feat: lottery opportunity email content updates feat: lottery opportunity email content updates (WIP) Dec 20, 2024
@jaredcwhite jaredcwhite changed the title feat: lottery opportunity email content updates (WIP) feat: lottery opportunity email content updates Jan 2, 2025
@jaredcwhite jaredcwhite changed the title feat: lottery opportunity email content updates feat: listing opportunity email content updates Jan 2, 2025
api/src/services/email.service.ts Outdated Show resolved Hide resolved
api/src/services/email.service.ts Outdated Show resolved Hide resolved
@ludtkemorgan
Copy link
Collaborator

@jaredcwhite I was able to test this locally and it looked good. I just have one comment about we the time zone, but once that is fixed and the merged conflicts are resolved this is good to merge!

@jaredcwhite
Copy link
Collaborator Author

Good call @ludtkemorgan! This will be more robust over time.

Copy link
Collaborator

@ludtkemorgan ludtkemorgan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making that change!

@ludtkemorgan ludtkemorgan merged commit e7b2647 into main Jan 7, 2025
16 checks passed
@ludtkemorgan ludtkemorgan deleted the 995/listing-opportunity-email branch January 7, 2025 14:49
@ludtkemorgan ludtkemorgan added ready to merge Should be applied when a PR has been reviewed and approved and removed 1 review needed labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge Should be applied when a PR has been reviewed and approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants