Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing strip-extra-keys-transformer for recursive map encoding #963

Merged
merged 1 commit into from
Dec 31, 2023

Conversation

tomasd
Copy link
Contributor

@tomasd tomasd commented Sep 26, 2023

This PR fixes an issue when strip-extra-keys-transformer was used to encode the :map-of used in a recursive way. Transformer needs to run before the encoder otherwise it sees already encoded value which does not pass the validation.

There is a pending issue when an invalid key in :map-of instead of being removed from the value invalidates the whole :map-of. This would probably require recursive validation, which may add some computational complexity.

@ikitommi
Copy link
Member

There is a pending issue when an invalid key in :map-of instead of being removed from the value invalidates the whole :map-of. This would probably require recursive validation, which may add some computational complexity.

a pending issue? but, merging this, thanks!

@ikitommi ikitommi merged commit 5fc4005 into metosin:master Dec 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants