fix review comment

metosin · Aug 28, 2024 · df62939 · df62939
1 parent 0bc3fa4
commit df62939
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/malli/generator.cljc b/src/malli/generator.cljc
@@ -172,7 +172,7 @@
        #(map (fn [[k :as e]]
                (cond-> e
                  (not= ::m/default k)
-                 (update 2 mu/merge [:map [dispatch [:= k]]]))) %)
+                 (update 2 mu/merge [:map [dispatch [:= nil k]]]))) %)
        (m/options schema)))))
 
 (defn -multi-gen [schema options]

diff --git a/test/malli/generator_test.cljc b/test/malli/generator_test.cljc
@@ -1116,4 +1116,11 @@
                   ["duck" :map]
                   [::m/default [:= "boss"]]]]
       (is (every? #{{:type "duck"} "boss"} (mg/sample schema)))
+      (is (every? (m/validator schema) (mg/sample schema)))))
+
+  (testing "works with nil & {} too"
+    (let [schema [:multi {:dispatch :type}
+                  [nil :map]
+                  [{} :map]]]
+      (is (every? #{{:type nil} {:type {}}} (mg/sample schema)))
       (is (every? (m/validator schema) (mg/sample schema))))))