Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not dispatch "complete" event on mount #26

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

jneuendorf-i4h
Copy link
Contributor

Fixes #21

Copy link
Owner

@metonym metonym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me – thank you for the fix!

@metonym metonym changed the title Avoid firing "complete" event on mount fix: do not dispatch "complete" event on mount Jun 13, 2024
@metonym metonym merged commit a301f8d into metonym:master Jun 13, 2024
1 check passed
@metonym
Copy link
Owner

metonym commented Jun 13, 2024

Released in v2.2.2.

@jneuendorf-i4h
Copy link
Contributor Author

Wow that quick 💪👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

on:complete is called immediately upon component mount.
2 participants